[dev/core#412] Avoid truncated UTF-8 strings when using substr()

[jensschuppe]

Overview

This fixes broken export forms when a custom group name contains a UTF-8 character at the 10th character position.

See dev/core#412.

Before

The export form can not be used due to a JavaScript error "Uncaught syntax error: Unexpected token ,".

The next column of options does not pop up.

After

The export form works correctly.

Technical Details

CRM_Core_BAO_Mapping::getCustomGroupName() truncates custom group names when longer than 10 characters using substr(), which causes multibyte characters being cut in half when at the truncating position.

This should use CRM_Utils_String::ellipsify() instead, which utilises mb_substr().

Comments

Maybe someone with more core code insight should inspect a grep substr( result for more places where that happens.

[civicrm-builder]

Can one of the admins verify this patch?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

Nice catch! @eileenmcnaughton @seamuslee001 Apparently this is an export form issue. Are you able to confirm the bug and proposed fix?

[seamuslee001]

Jenkins add to whitelist

[eileenmcnaughton]

I was able to replicate this & confirm the fix. Merging