Ensure hard-coded date ranges are preserved in smart groups #12909
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://lab.civicrm.org/dev/core/issues/396
Overview
Due to a regression introduced by #11486, smart groups based on manually entered date ranges fail to properly filter by the date ranges when executed.
Before
If you create a smart group based on a search using one of several specially identified date fields (including event participant registration date) and you manually specify a date range instead of selecting a pre-chosen range, then your smart group will be properly saved, but the date range will be ignored when the saved search is executed.
After
Smart groups based on manually selected date ranges properly select the right contacts based on the date ranges entered.
Technical Details
Prior to the fix, CiviCRM issued an undefined index error.
Comments
This is a reviewer's commit. I reviewed @jmcclelland patch & decided