[NFC] Minor cleanup, return preferred parameter

[eileenmcnaughton]

Overview

Minor code clean up - no actual impact

Before

$result returned from Contribute_BAO_ContributionRecur::create

After

$recurring returned from Contribute_BAO_ContributionRecur::create

Technical Details

The result parameter is the same as $recurring (save()) returns $this. But
it's more correct to return $recurring than result as
a) it's defined as a Contribute_BAO_ContributionRecur object which is correct.
b) it's the object passed through hooks

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@mattwire as discussed

[mattwire]

This is basically code cleanup. It does have a small impact in that $recurring will now hold the result of any changes made by the hook but this is the correct/expected behaviour. Ok to merge

[eileenmcnaughton]

fails unrelated, merigng based on Matt review