Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons to top-level navigation menu #12878

Merged
merged 3 commits into from
Sep 28, 2018
Merged

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Sep 27, 2018

Overview

Title and screenshot says it all.

screenshot from 2018-09-27 15-42-52

@colemanw
Copy link
Member Author

@kcristiano can you test this on a new install? I've tested the upgrade script but haven't tried installing it from scratch.

@kcristiano
Copy link
Member

@colemanw The icons do not show on install for both WP and Drupal 7. This was tested with both a buildkit install and a tarball created via distmaker/civihydra.

However, the expected sql is in sql/civicrm_navigation.sql so I am unsure why this fails. If I force an upgrade the icons then appear as expected.

@seamuslee001
Copy link
Contributor

@colemanw i think you need to do ./bin/regen.sh to ensure the changes get into the civicrm_generated sql

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@kcristiano
Copy link
Member

Retested after regenerating the sql and new installs are showing the icons.

@colemanw
Copy link
Member Author

@civicrm-builder retest this please

@colemanw
Copy link
Member Author

Thanks for the inspiration and the review @kcristiano!

@seamuslee001
Copy link
Contributor

@civicrm-builder re test this please

@seamuslee001
Copy link
Contributor

test fails unrelated

@seamuslee001 seamuslee001 merged commit 05919ff into civicrm:master Sep 28, 2018
@colemanw colemanw deleted the menu-icons branch September 28, 2018 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants