-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icons to top-level navigation menu #12878
Conversation
@kcristiano can you test this on a new install? I've tested the upgrade script but haven't tried installing it from scratch. |
@colemanw The icons do not show on install for both WP and Drupal 7. This was tested with both a buildkit install and a tarball created via distmaker/civihydra. However, the expected sql is in sql/civicrm_navigation.sql so I am unsure why this fails. If I force an upgrade the icons then appear as expected. |
@colemanw i think you need to do ./bin/regen.sh to ensure the changes get into the civicrm_generated sql |
Jenkins re test this please |
Retested after regenerating the sql and new installs are showing the icons. |
@civicrm-builder retest this please |
Thanks for the inspiration and the review @kcristiano! |
@civicrm-builder re test this please |
test fails unrelated |
Overview
Title and screenshot says it all.