Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Stray Extra Div in Case Dashboard TPL #12848

Merged
merged 1 commit into from
Sep 20, 2018

Conversation

gah242s
Copy link
Contributor

@gah242s gah242s commented Sep 20, 2018

Overview

Looks like there is an extra tag at the bottom of this file. The WordPress footer was coming up into the middle of the page.

Before

WP-Footer shows up in the middle of the page.

image pasted at 2018-9-20 09-02

After

WP-Footer shows up in correct location at the bottom of the page.

Technical Details

Comments

Discussion threads on MM:
https://chat.civicrm.org/civicrm/pl/9eywqazzt3yb5e49jg9yh71rfh
https://chat.civicrm.org/civicrm/pl/taebbfneutyrfdh7ed9srhoiwy

Looks like there is an extra </div> tag at the bottom of this file.  The WordPress footer was coming up into the middle of the page.  Discussion threads on MM:  
https://chat.civicrm.org/civicrm/pl/9eywqazzt3yb5e49jg9yh71rfh
https://chat.civicrm.org/civicrm/pl/taebbfneutyrfdh7ed9srhoiwy
@seamuslee001 seamuslee001 changed the title Update DashBoard.tpl Remove Stray Extra Div in Case Dashboard TPL Sep 20, 2018
@seamuslee001
Copy link
Contributor

@gah242s I have updated the title to be more explicit about what this is doing.

@seamuslee001
Copy link
Contributor

(CiviCRM Review Template WORD-1.1)

  • (r-explain) Pass
  • (r-test) Pass (test failures unrelated)
  • (r-code) Pass
  • (r-doc) Pass
  • (r-maint) Pass
  • (r-run) Pass tested on Drupal and Wordpress, confirmed the issue shows on Wordpress, confirmed this fixes it and confirmed on Drupal that no change was made there
  • (r-user) Pass
  • (r-tech) Pass

@seamuslee001 seamuslee001 merged commit 6aff8e3 into civicrm:master Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants