dev/core#393 Allow 0 as a valid option value when option group data_type is Integer

[MegaphoneJon]

…ata_type is Integer

Overview

The check for invalid option values gives a false positive when the option group's data_type is Integer and the value is 0. This is particularly noticeable when you have the "Related Permissions" extension version 1.5 installed.

Before

A notice appears in the System Status screen.

After

No notice appears.

Technical Details

This is a truthiness issue.

Comments

Steps to replicate manually are on the Gitlab issue but a phpunit test is included which you can run with/without the functional change.

[eileenmcnaughton]

Thanks @MegaphoneJon this looks good. Thanks for the test too.

In general I believe we should err-on-merge for any changes that make system checks looser as they are not supposed to interfere on correct sites & that is probably more important than their existance