Fixes to Contact Detail report #12772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pradpnayak the issue occurs only when a hook is in play? Are you able to add a test on this? |
eileenmcnaughton
added
the
sig:extension support
|
I've worked my way through this & most of the changes are just removing unused cruft. The significant change is not passing the component clauses out to the hook - as they are not used in the main query & can result in fatal errors. I was able to replicate the issue in a test which I will submit. |
|
test this please |
|
@pradpnayak test fails are style related. Also, my unit test is merged I think so you could remove the line that skips this report as part of this PR & hence add testing with it |
pradpnayak
force-pushed
the
DetailContactReport
branch
from
8de6f8e to
873ca02
Compare
|
Thanks @eileenmcnaughton I have pushed the changes. Can you please have a look? |
|
looks good @pradpnayak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
selectWhereClause() hook breaks when trying to add clause for contact table.
https://lab.civicrm.org/dev/core/issues/376
Before
DB Error: no such field [nativecode=1054 ** Unknown column 'relationship_civireport.contact_id_a' in 'where clause']"]
After
No DB error
Technical Details