Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#276 enotice fix #12563

Merged
merged 1 commit into from
Jul 26, 2018
Merged

dev/core#276 enotice fix #12563

merged 1 commit into from
Jul 26, 2018

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 25, 2018 •
edited
Loading

Overview

Fix regression (causes enotice only)

Before

Enotice

After

No enotice

Technical Details

Fixes a trivial 5.0 regression causing an enotice #11622

Comments

@civibot
Copy link

civibot bot commented Jul 25, 2018

(Standard links)

@eileenmcnaughton eileenmcnaughton mentioned this pull request Jul 25, 2018
Merged
@eileenmcnaughton
Copy link
Contributor Author

@totten wanna add Merge on pass to the 5.4 version too

@seamuslee001
Copy link
Contributor

Change makes sense resolves an E-notice the 5.3 PR was merge-on pass and happy to merge this likewise

@seamuslee001 seamuslee001 merged commit 8bb4520 into civicrm:5.4 Jul 26, 2018
@eileenmcnaughton eileenmcnaughton deleted the enotice54 branch July 26, 2018 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @seamuslee001 @civicrm-builder