Handle 'Check for Matching Contact(s)' button with ajax

[colemanw]

Overview

Fixes the 'Check for Matching Contact(s)' button when ajax deduping is enabled

Before

The button would still work if ajax deduping was disabled in system prefs, but didn't work if ajax mode is enabled.

After

The button works either way. If ajax mode is enabled, clicking the button will use ajax. Otherwise it does it the old way.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[robfenwickuk]

I have tested the patch for this, and the button still does not work after the patch, unless AJAX Deduping is disabled. I see the same behaviour - the screen refreshes, with no alert or message. I am on 5.3.1 on Drupal 7.

[seamuslee001]

@robfenwickuk did you ensure that you removed every line that needed removing? I tested and found it worked fine for me on a buildkit install of 5.3.1 with this patch applied

[robfenwickuk]

@seamuslee001 I must confess to being a github n00b, so what I did was go here:

https://github.com/colemanw/civicrm-core/blob/4cdfcee742776c1371ee13258f9cddd7e5187b84/templates/CRM/Contact/Form/Contact.tpl

Click raw, and then copied & pasted that to overwrite /sites/all/modules/civicrm/templates/CRM/Contact/Form/Contact.tpl in its entirety

[colemanw]

@robfenwickuk it could be that there is some javascript error on your site which is preventing it from working. Can you try opening up the console (F12) and then go to the "New Individual" form, and click that "Check for matching contacts" button. See if any red error messages show up in your console.
Or if you like, I can log in and take a look if you want to email me login info for your site (my first name @civicrm.org is my email address)
- Coleman

[colemanw]

Ok @robfenwickuk has been super helpful with testing out various workflows and I think we've finally got it all working. Now we've tested:

• Create new contact: check while typing
• Create new contact: click the check button (ajax mode)
• Create new contact: click the check button (non-ajax mode)
• Edit contact: check while typing (should do nothing)
• Edit contact: click the check button (ajax mode)
• Edit contact: click the check button (non-ajax mode)

The latest commit ensures that when editing an existing contact, they will not show up in the list of duplicates!

[colemanw]

@robfenwickuk can you confirm that you've tested all of the above? Thanks so much for your help with this :)

[robfenwickuk]

@colemanw I can confirm I've now fully tested this and it is totally fixed. Thank you for your efforts! Much appreciated.

[colemanw]

Thanks @robfenwickuk for reporting this and diligently testing. And also thanks @seamuslee001 and @eileenmcnaughton for your help.