Shoreditch support: Fix following change in core that resulted in visual regression in shoreditch in advanced search #12524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
changed the title
|
Given this merge on pass as we have added similar PRs adding line breaks before. I guess just fixing things like this is OK - but there's nothing to stop it from keeping happening & nothing other than you reviewing PRs to pick it up. The work Compucorp did here #12078 would be a more robust approach (although overkill for this fix). Not sure what else can be done to prevent layout issues affecting shoreditch - some clever test screenshotting regime? Some other html approach - dunno |
eileenmcnaughton
changed the title
|
Merging as per the tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR for regression issues Advanced search.
Before
After