CRM-21574 Allow to disable sending of email from source contact for tell a friend on pcp

[mattwire]

Overview

When sending emails for personal campaign pages and enabling the "Tell a Friend" functionality it tries to send email from the contact IDs email address. However this is not always desirable as it can break SPF/DMARC and lead to bounced/failed email delivery.

Ref: #11425

---

• CRM-21574: Allow to disable sending of email from source contact for tell a friend on pcp
• CRM-21244: Enhancements to "FROM email addresses"

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

ping @mlutfy Mathieu i think you might know a thing or two on this

[mlutfy]

I tested and it did not seem to work because the email_from would end up empty, then somehow the contact's primary email still gets set.

This fixes the issue for me:

    if (Civi::settings()->get('allow_mail_from_logged_in_contact')) {
      // use contact email, CRM-4963
      if (empty($values['email_from'])) {
        $values['email_from'] = $email;
      }
    }

    // Added this ⏬⏬⏬⏬⏬⏬⏬⏬⏬⏬⏬⏬
    if (empty($values['email_from'])) {
      $domainValues = CRM_Core_BAO_Domain::getNameAndEmail();
      $values['email_from'] = $domainValues[1];
    }

The code later does:

            'from' => "$fromName (via {$values['domain']}) <{$values['email_from']}>",

So this seems safer imho.

[eileenmcnaughton]

@mattwire this one is in your court

[mattwire]

@mlutfy Thanks for reviewing, I've updated the PR to reflect the changes you suggested - could you confirm if it is ok now?

[mlutfy]

@mattwire Tested and works great. Merging. Thank you!