Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(NFC) dev/core#174 - CRM_Utils_System::flushCache - Remove dead code #12323

Merged
merged 1 commit into from
Jun 17, 2018
Merged

(NFC) dev/core#174 - CRM_Utils_System::flushCache - Remove dead code #12323

merged 1 commit into from
Jun 17, 2018

Conversation

totten
Copy link
Member

@totten totten commented Jun 16, 2018 •
edited
Loading

Before

  • The signature of CRM_Utils_System::flushCache does not accept arguments.
  • Random forms call it with an unused argument.

After

  • The signature of CRM_Utils_System::flushCache does not accept arguments.
  • Random forms call it without any arguments.

@totten
(NFC) dev/core#174 - CRM_Utils_System::flushCache - Remove dead code
d7d6c46 
Before
------

* The signature of `CRM_Utils_System::flushCache` does not accept arguments.
* Random forms call it with arguments.

After
-----

* The signature of `CRM_Utils_System::flushCache` does not accept arguments.
* Random forms call it without arguments.
@civibot
Copy link

civibot bot commented Jun 16, 2018

(Standard links)

@eileenmcnaughton
Copy link
Contributor

I concur :-)

@eileenmcnaughton eileenmcnaughton merged commit 369000f into civicrm:master Jun 17, 2018
@totten totten deleted the master-flush-sig branch August 1, 2018 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master sig:code maintenance readability testability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@totten @eileenmcnaughton @civicrm-builder