Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev/core#179) Redis - Only send AUTH if there's a password #12304

Merged
merged 1 commit into from
Jun 13, 2018

Conversation

totten
Copy link
Member

@totten totten commented Jun 12, 2018

Overview

The Redis driver always sends a password. That's well and good in production. However, if you're doing local development, the dev instance of redis may be configured to allow local-only, unauthenticated connections -- for which no password is available.

Before

If you don't use/need a password, the Redis driver sends an inappropriate AUTH command.

After

If you don't use/need a password, the Redis driver does not send an AUTH command.

@civibot
Copy link

civibot bot commented Jun 12, 2018

(Standard links)

@colemanw
Copy link
Member

Looks simple & safe.

@colemanw colemanw merged commit 7463429 into civicrm:master Jun 13, 2018
@totten totten deleted the master-redis-anon branch June 13, 2018 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants