dev/core#175 - Smart group involving relationship type filter display…

[jitendrapurohit]

… incorrect results

Overview

Smart group involving relationship type filter display incorrect results.

Before

replicated on dmaster -

• Advanced Search -> Relationship tab -> type = Employer of (or any b_a reln type) -> Search (results all organization contacts).
• Proceed and add all of them to a smart group.
• When you click on Done after creating smart group, you are navigated to advanced search result with the contacts belonging to this group. All contacts are incorrectly displayed.

Another way to replicate -

• Advanced Search -> Relationship tab -> type = Employer of (or any b_a reln type) -> Search (results all organization contacts).
• Click on Search button again. All contacts are replaced with Employee of relationship

After

Smart groups and new search results are fixed.

Technical Details

Not sure why static variable is appended with the reltype value. Mostly, this seems to be a typo added in https://github.com/civicrm/civicrm-core/pull/11595/files. @seamuslee001 Can you pls confirm?

Comments

Added unit test.

---

Gitlab Issue - https://lab.civicrm.org/dev/core/issues/175

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Agree it looks like a typo on my part,

(CiviCRM Review Template WORD-1.1)

• (r-explain) Pass
• (r-test) Pass
• (r-code) Pass
• (r-doc) Pass
• (r-maint) Pass
• (r-run) Pass Replicated fix and confirmed it works as expected
• (r-user) Pass
• (r-tech) Pass

ping @mlutfy Mathieu this maybe relevant to you