Remove unused code variable

[eileenmcnaughton]

Overview

Code readability fix - $objects is passed to cancelRecurContribution but never used, tidy up

Before

Code less readable

After

Code more readable

Technical Details

If $objects is set then the ipn cancelled() function is called. It is never set & the function appears intended to deal with a cancelled payment not a cancelled recurring so this just seems to be a code hangover

I checked the places this is called from

$objects is null, $activity_params does not contain 'source_record_id'
      $activityParams
        = array(
          'subject' => $this->_mid ? ts('Auto-renewal membership cancelled') : ts('Recurring contribution cancelled'),
          'details' => $message,
        );
      $cancelStatus = CRM_Contribute_BAO_ContributionRecur::cancelRecurContribution(
        $this->_subscriptionDetails->recur_id,
        NULL,
        $activityParams
      );

object & activity params are both null

  return CRM_Contribute_BAO_ContributionRecur::cancelRecurContribution($params['id'], CRM_Core_DAO::$_nullObject) ? civicrm_api3_create_success() : civicrm_api3_create_error(ts('Error while cancelling recurring contribution'));

object & activity params are both null

    CRM_Contribute_BAO_ContributionRecur::cancelRecurContribution($contributionRecur['id'], NULL);

Comments

Follow up from #11964

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).