Use email_greeting where possible in receipts

[eileenmcnaughton]

Overview

Adds the use of the email_greeting to the default message templates - e.g for individuals a line like

Dear Mickey,

would be added. For organisations it is not added. Customised templates unchanged.

Before

No greeting

After

greeting

Technical Details

This is a recut of #11674

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[colemanw]

I'm confused about what's going on here. Why assign a variable?

[eileenmcnaughton]

to avoid a comma if there is none

[colemanw]

The old code appears to already be doing that. Am I missing something?

[eileenmcnaughton]

@colemanw I only just added the old code on this template (as part of getting the message update functionality merged - I used it as an example). When I tested as part of this it didn't work

[eileenmcnaughton]

@colemanw note change from {if $contact.email_greeting} to {contact.email_greeting} - it's not a smarty token

[JoeMurray]

1. There are likely other templates that should be changed if you're going to do it for these three. My sense: at least the three offline receipts too. Why not for even more at same time?

2. With recent change around? not overwriting customized templates when the default template is upgraded, is there a notice given to folks on upgrade about what has changed in templates that they should maybe be aware of? These seem like simple updates that people could incorporate, but folks will not be aware they are available if I recall correctly the process.

[eileenmcnaughton]

@JoeMurray to be honest I just changed the things from #11674 so I could resolve that pr - I don't grow it further but the submitter can if they want

I agree re messages but this has grown more than enough for this round of trying to deal with pr above

[eileenmcnaughton]

@colemanw are you OK to merge this - there is another tpl update that @aydun needs to do but we need to get this merged first

[eileenmcnaughton]

@colemanw would be good to get this merged for the rc

[seamuslee001]

Change makes sense to me and i believe these are all good improvements

[seamuslee001]

(CiviCRM Review Template WORD-1.1)

• (r-explain) Pass
• (r-test) Pass
• (r-code) Pass
• (r-doc) Pass
• (r-maint) Pass
• (r-run) Pass
• (r-user) Pass
• (r-tech) Pass

[eileenmcnaughton]

Thanks @seamuslee001 (ping @magnolia61 - will be in 5.4)

[agh1]

cross-referencing here: it looks like this addresses (maybe completes?) CRM-20184

[eileenmcnaughton]

I think so - I'll close CRM-20184 - if there are missed places it can go in a follow up