dev/core#158 group contacts list and export limits results to 500 records

[eileenmcnaughton]

Overview

This is an alternative to #12244 - it fixes an intra-rc regression caused by this change
https://github.com/civicrm/civicrm-core/pull/12110/files#diff-35d8774ba8df60e417bb7f9d95f5578dL112

Before

From Manage groups screen only 500 contacts exported. E-notices

After

All contacts export - even when more than 500 are in the group

Technical Details

The issue was that

$values = $this->controller->exportValues('Search');

was not working as the form for contact is 'Basic' thus the 'export all records' was being lost, with flow on effects.

The reason it was lost was $components went from

$components = array('Contribute', 'Member', 'Event', 'Pledge', 'Case', 'Grant', 'Activity');

to

$components = array('Contact', 'Contribute', 'Member', 'Event', 'Pledge', 'Case', 'Grant', 'Activity');

So the line

if (in_array($entityShortname, $components)) {

was not returning the correct resuls

Comments

This really needs to be fixed for tomorrow's release. I have a high degree of confidence having exported from both the basic screen & manage groups & based on stepping through the code & seeing it fail to populate and being able to find the specific recent error causing it.
Hence, I am going to self-merge this to ensure it is in the release

ping @lcdservices @mattwire @kcristiano

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[kcristiano]

thanks @eileenmcnaughton

I applied the RC plus this patch to an upgraded database with groups having over 500 contacts in them.

I can export from both screens (basic & via manage groups) as well.

I appreciate you pushing this into this release.

[lcdservices]

I ran through tests and this is working as expected for me as well.

[eileenmcnaughton]

thanks @kcristiano & @lcdservices