dev/core#154 - Can't edit related records when current employer has a… #12266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
CRM/Contact/BAO/Relationship.php
Outdated
| @@ -1736,6 +1736,10 @@ public static function relatedMemberships($contactId, &$params, $ids, $action = | |||
| //contact before creating new membership record. | |||
| CRM_Member_BAO_Membership::deleteRelatedMemberships($membershipId, $relatedContactId); | |||
| } | |||
| //skip status calculation for pay later memberships. | |||
| if (!empty($membershipValues['is_pay_later']) && !empty($membershipValues['status_id'])) { | |||
There was a problem hiding this comment.
I feel like it's the pendingness not the pay-later-ness that means we should skip the calc? That might be more reliable to check?
There was a problem hiding this comment.
Can't find any problems in modifying the above check to pending. I've updated the PR to look for the same now. Cheers 👍
… pending membership check for pending status instead of pay later
|
OK - I think this is good to merge if it passes tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… pending membership
Overview
Fix fatal error while creating a relationship with a contact holding pending membership.
Before
Fatal Error on creating current employer relationship with the organization holding pending membership.
Can be replicated using below steps -
After
Fixed. Adding current employer relationship in the last step inherits the membership correctly.
Technical Details
Avoid status calculation for relationship which creates a membership for pay later record.
Comments
Added unit test.
Gitlab - https://lab.civicrm.org/dev/core/issues/154