dev/mail#13 - All members should not be excluded from Smart unsubscribe group

[monishdeb]

Overview

https://lab.civicrm.org/dev/mail/issues/13

All unsubscribe group members are excluded from a mailing with a manually specified unsubscribe group (group_type=Base) if the unsubscribe group is a Smart group.

To reproduce: Create a smart group with some members in it. Some members may also be added and removed manually as usual. Search for some contacts including some who are in that smart group and choose the action to send/schedule a bulk email. When creating the mail select the Smart group as your unsubscribe group.

The expected result: The mailing is not sent to any contacts in the search who are in the smart un-subscribe group with the status "Removed".

Before

The result: The mailing is not sent to any contacts in the search who are in the smart un-subscribe group at all.

After

The expected result

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

This is a patch @monishdeb reviewed against master & decided to put against 5.2 as a (somewhat) recent regression. merge-on-pass