Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#160 Set the import progress widget to poll the server every … #12252

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

seamuslee001
Copy link
Contributor

…5s rather than every 5ms

Overview

This sets the interval at which the import progress bar should poll the server to be 5s rather than 5ms

Before

Import progress bar could generate an equivilant to a DOS attack on a server as it was polling over 200times a second
After

importer only polls the server every 5s

It appears that the 5 was meant to be s but the js is believing its ms

ping @monishdeb @colemanw @eileenmcnaughton

@eileenmcnaughton
Copy link
Contributor

OK - this seems to bear out @seamuslee001 analysis of the variable type https://www.w3schools.com/jsref/met_win_setinterval.asp & also @seamuslee001 advises it has had internal testing - merging

@eileenmcnaughton eileenmcnaughton merged commit 356de9e into civicrm:master Jun 5, 2018
@eileenmcnaughton eileenmcnaughton deleted the dev_core_160 branch June 5, 2018 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants