dev/core#149 - Fatal Error on customvalue get api

[jitendrapurohit]

Overview

Fix fatal error on custom value get api.

Before

Custom Value get API fails with a fatal error.

$result = civicrm_api3('CustomValue', 'get', [
  'sequential' => 1,
  'return' => "custom_1",
  'entity_id' => 202,
]];

Result -

"is_error": 1,
"error_message": "A fatal error was triggered:  is not of type String"

After

Fixed.

Technical Details

Incorrect parameter passed in civicrm_api3_custom_value_get() fucntion.

Comments

Added unit test.

---

Gitlab Issue - https://lab.civicrm.org/dev/core/issues/149

[colemanw]

The existing code seems to be supporting a syntax like:

$result = civicrm_api3('CustomValue', 'get', [
  'return.custom_1' => 1,
  'return.custom_2' => 1,
  'return.custom_3' => 1,
  'entity_id' => 202,
]];

I suspect this change will break any code using that syntax.

If we want to support the alternate syntax of 'return' => ['custom_1', 'custom_2', 'custom_3'] then that would be fine, but this PR doesn't seem to do that.

[jitendrapurohit]

Updated the PR to support all the return value syntax. Thanks @colemanw

[colemanw]

Could you please also add 2 more scenarios to this test?

1. Multiple fields to return (array format)
2. Multiple fields to return ('return.custom_x' => 1 format)

[jitendrapurohit]

Updated unit test to cover above scenarios as well 👍

[colemanw]

Test coverage is good now. Merging.