Towards dev/financial/#16 Paypal unreliable getting payment processor type #12171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… type This is a partial reviewer's commit on the work Matt did in civicrm#12007 (comment) It adds the new function & new construct but I spotted an error in the usage of the function & so want to add the usage changes more slowly & carefully
|
Unrelated fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a partial reviewer's commit on the work Matt did in
#12007 (comment)
It adds the new function & new construct but I spotted an error in
the usage of the function & so want to add the usage changes more slowly
& carefully
Before
Under some circumstances (not clear which, we should add a deprecated to find & eliminate) the paypal type may not be determined properly
After
Helper function added to prevent issue
Technical Details
@mattwire has been working on this & it is a good change. However in review I spotted a place where the wrong processor is referenced (https://github.com/civicrm/civicrm-core/pull/12091/files#diff-96a0ea19e8ac102ef100c35b3b3d1c31R506) & felt uncomfortable updating many places at once so introducing the helper first to do the other changes very carefully
Comments
Giving merge on pass as a reviewer's commit