Dev/Core#120 Advanced Search - Contacts throws Fata Error v 5.1.1 #12147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o get tests to pass so we can switch to using MySQL 5.7 for PR Tests
…o be more expliict about what the function does
|
I have tested this on Drupal 7 and WP and this fixes the stated issue. |
|
@civicrm-builder retest this please |
|
Test fails are fine - we know 5.1 can't pass on these tests |
|
@eileenmcnaughton can you also backport your report pager fix then as monish has changed CRM/Report/Form.php here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is f/u PR of #12064 and #12043 which is missed on v5.1.1 and caused a regression due after merging #12074 #11996 against 5.1 which depends on those two fn.