Add DB default of 0 for custom_group.is_multiple - CRM-21853

[eileenmcnaughton]

Overview

Make the civicrm_custom_group.is_multiple field DB default = 0 (to resolve #11877). I also set is_active to default to 1 while I was at it as it seemed broadly consistent with other tables

Before

No default for field civicrm_custom_group.is_multiple

After

Default is 0

Technical Details

Tests should pass on #11877 after this & it should be mergeable

Comments

@mickadoo this is to try to resolve an older PR of yours. I thought about closing it but decided the missing piece of work was relatively trivial

---

• CRM-21853: Edting CustomGroup always sets is_multiple to false by default

[eileenmcnaughton]

@seamuslee001 @monishdeb @colemanw is one of you up to review this - removes a blocker to getting an old PR by Compucorp merged (& that PR fixes a bug)

[seamuslee001]

Changes look ok to me @eileenmcnaughton have you tested on different MySQL engines in case the SET command doesn't work on all versions?

[mickadoo]

Thanks for doing this @eileenmcnaughton, it's been on my list to get back to this since you suggested making a default, but since we added a workaround in the feature I was working on it was lower priority. It would be great to get this fixed cleanly by adding the db default.

[eileenmcnaughton]

@seamuslee001 I think that UPDATE command is pretty standard mysql isn't it?

[seamuslee001]

(CiviCRM Review Template WORD-1.1)

• (r-explain) Pass
• (r-test) Pass
• (r-code) Pass
• (r-doc) Pass
• (r-maint) Pass
• (r-run) Pass ran the upgrade confirmed the defaults were altered correctly, Also verified by checking the SET statement in the alter table should work fine on Maria as per https://mariadb.com/kb/en/library/alter-table/
• (r-user) Pass
• (r-tech) Pass

[seamuslee001]

Merging