Fix Soft credit personal note ton limit to 255 characters (DB limit). #12056
Conversation
| @@ -453,7 +453,7 @@ public static function buildPcp($pcpId, &$page, &$elements = NULL) { | |||
| $page->_defaults['pcp_is_anonymous'] = 0; | |||
|
|
|||
| $page->add('text', 'pcp_roll_nickname', ts('Name'), array('maxlength' => 30)); | |||
There was a problem hiding this comment.
as @KarinG indicated, this also need to be changed to $page->addField('pcp_roll_nickname', ['entity' => 'ContributionSoft', 'context' => 'create']);
There was a problem hiding this comment.
Yep - I don't want to scope-creep this to other fields
|
Note this requires @KarinG to confirm she has tested it |
|
I'm sorry but I get cannot apply patch on this PR/8 files (and the prerequisite XML PR/1 file) to the 4.7.x site that I have PCP Events in production on - or I would roll this out to our sites right now. So all I could do is do exactly what you have already done - on a brand new vanilla civibuild 5.x - I don't need to replicate that; Time is very limited at the moment with CiviCamp Calgary only weeks away now. |
|
@KarinG - OK well we need someone to replicate before we can merge somewhere - that's our requirement. If you can't do it then it can wait until someone does want to put the time into doing that. On a vanilla 5.x is fine but it does need to go through the review hoops |
|
@KarinG why don't you do it at the sprint - it's probably a twenty minute job to finish review at this point & the sprint might be a good time |
Note that some special characters can still cause it to spill over but that will affect other fields too & we should consider a bigger fix if we need to. Also fixed deprecation notices
|
test this please |
|
(test fail unrelated but still better to get a green) |
|
I have tested the patch for PCP Hence merging this PR. |
|
Thanks @monishdeb I know you are busy and this did not affect any of your customers but I appreciate getting it wrapped up |
Overview
Fix Soft credit personal note ton limit to 255 characters (DB limit).
Alternate to #12044 - replication details are the same & max impact is the same. As I needed to go into the code to do the fix proposed on the other PR I also fixed all the deprecation notices I hit at the same time (although not the one e-notice at the very end)
@KarinG can you please test & review this - it solves the same problem as your PR but per comments on that PR it uses the approach that we suggested on your PR