WIP Add set of standard money formatter functions #12055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwire
force-pushed
the
money_formatters
branch
from
071c7fc to
a918621
Compare
mattwire
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add a set of standard money formatter functions that allow us to be consistent with the display and submission of monetary amounts. This allows us to ensure that monetary amounts are formatted appropriately for the locale / payment processor etc. rather than relying on custom functions or the somewhat multipurpose but inconsistent CRM_Utils_Money::format function.
This would help fix #12042 and #12019
Before
Standard formatters not available.
After
Standard formatters available.