(NFC) Update version in header #11999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple administrative update to the headers. It was generated with the command: ``` rgrep '| CiviCRM version 4.7' CRM/ Civi ang api bin extern install/ settings/ templates -l \ | xargs sed -i'' "s/| CiviCRM version 4.7/| CiviCRM version 5 /g" ``` Tthe inclusion of `|` aimed to avoid matching any non-header text (e.g. inline docs that mentioned the version incidentally). But then I did a looser search and for just ``` rgrep 'CiviCRM version 4.7' ```` and manually patched the remainder. Note: I'm not really keen on doing this every month, so I relaxed the header statement -- instead of `CiviCRM version 5.0`, it's just `CiviCRM version 5`.
|
I spot checked 20 or so files & change seems solid. |
totten
added a commit
to totten/civicrm-core
that referenced
this pull request
Apr 25, 2018
This is a simple administrative update to the headers. It's a follow-up to civicrm#11999 (fee1419). This addresses a small discrepancy -- after running GenCode locally, some files would be changed back to `version 4.7`. Now they'll stay as `version 5`.
totten
added a commit
to totten/civicrm-core
that referenced
this pull request
Apr 25, 2018
This is a simple administrative update to the headers. It's a follow-up to civicrm#11999 (fee1419) which addresses some files missed by the previous search.
totten
added a commit
to totten/civicrm-core
that referenced
this pull request
Apr 25, 2018
This is a simple administrative update to the headers. It's a follow-up to civicrm#11999 (fee1419) which addresses some files missed by the previous search.
totten
added a commit
to totten/civicrm-core
that referenced
this pull request
Apr 25, 2018
This is a simple administrative update to the headers. It's a follow-up to civicrm#11999 (fee1419) which addresses some files missed by the previous search.
totten
added a commit
to totten/civicrm-core
that referenced
this pull request
Apr 25, 2018
This is a simple administrative update to the headers. It's a follow-up to civicrm#11999 (fee1419) which addresses some files missed by the previous search.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple administrative update to the headers. It was generated with the command:
The inclusion of
|aimed to avoid matching any non-header text (e.g. inline docs thatmentioned the version incidentally). But then I did a looser search for just
and manually patched the remainder.
Note: I'm not really keen on doing this every month, so I relaxed the header
statement -- instead of
CiviCRM version 5.0, it's justCiviCRM version 5.