-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev/translation#9 Create API Action to rebuild Multilingual Schema #11967
dev/translation#9 Create API Action to rebuild Multilingual Schema #11967
Conversation
d44b92a
to
f86232b
Compare
api/v3/System.php
Outdated
* Rebuild Multilingual Schema | ||
* | ||
*/ | ||
function civicrm_api3_system_rebuildMultilingualSchema() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
convention is all lower
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorted
I'm happy with this in principle - I can't see a downside |
f86232b
to
f8a6a24
Compare
@seamuslee001 can we alter an existing test to call this? I could make a case for not having a test here - but it also feels like it might not be that hard if there are existing tests |
I wonder if we should tie in with system.flush api (that rebuilds triggers if trigger=1) |
Yeh might be not the worst idea |
api/v3/System.php
Outdated
return civicrm_api3_create_success(1); | ||
} | ||
else { | ||
throw new API_Exception('Cannot call rebuild Multilingual scheama on non Multilingual database'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in "scheama"
I was also initially going to suggest
whereas we also have |
Yeah - I'm kinda 6 one way & half a dozen the other on adding to flush vs it's own fn |
@seamuslee001 Can you fix the typo, and we can merge? |
@mlutfy done |
f8a6a24
to
7fb9179
Compare
Merging this as on balance it helps us deal with support issues & any downside is kinda esoteric |
Overview
Create an API tool to allow folks to rebuild the multilingual schema
Before
Have to use cli tools to rebuild schema
After
able to rebuild schema using the API
ping @eileenmcnaughton @mlutfy This isn't the perfect solution at least it should make it easier for folks to get out of trouble hopefully