Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent hard-fail when section header / group by option chosen on logging report #11953

Merged
merged 1 commit into from
Apr 16, 2018

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Prevent hard-fail when section header / group by option chosen on logging report

The contact logging summary report permits 'Section Header / Group By' in the order by tab but it doesn't work, badly.

screenshot 2018-04-06 12 30 41

Before

screenshot 2018-04-06 12 30 29

After

screenshot 2018-04-06 12 31 00

Or by contact
screenshot 2018-04-06 12 37 20

Technical Details

I'm not convinced the option is terribly valid /important in this report but if chosen it should not give a fatal error. I tested 2 criteria & both gave a fatal. This is just a quick fix to prevent that. It does not populate the count - hence the empty brackets but I see that as low priority - perhaps no-one will ever care level of issue

@eileenmcnaughton
Copy link
Contributor Author

test this please

@seamuslee001
Copy link
Contributor

I'm happy with this and makes sense

(CiviCRM Review Template WORD-1.1)

@seamuslee001 seamuslee001 merged commit dcea865 into civicrm:master Apr 16, 2018
@eileenmcnaughton eileenmcnaughton deleted the section_fail branch April 16, 2018 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants