CRM-21677 reduce unnecessary joins in reports #11889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test this |
|
test this please |
|
(unrelated fail, paypal should throw an exception for that fn to work) |
yashodha
approved these changes
Mar 29, 2018
| $this->_from .= "LEFT JOIN civicrm_email {$this->_aliases['civicrm_email']} ON {$this->_aliases['civicrm_contact']}.id = {$this->_aliases['civicrm_email']}.contact_id AND {$this->_aliases['civicrm_email']}.is_primary = 1\n"; | ||
| } | ||
| $this->joinAddressFromContact(); | ||
| $this->joinEmailFromContact(); | ||
| } |
There was a problem hiding this comment.
@eileenmcnaughton I don't see any email/address columns in Membership Summary report
There was a problem hiding this comment.
Hmm - in construct I see
'civicrm_email' => array(
'dao' => 'CRM_Core_DAO_Email',
'fields' => array('email' => NULL),
'grouping' => 'contact-fields',
),
which seems kinda weird!
There was a problem hiding this comment.
Same in memberDetail too TBH - what do you think? I'm inclined to merge this as more standardised & safer than stripping out the join. We could also add more email fields/filters - but I'm wary of growing the scope for something neither of us are vested in
|
merging based o your approval @yashodha & because it doesn't make the issue you noted worse - but we could follow up on that if we choose |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Reviewers cut of #11550 - reduce unnecessary joins to address tables in reports
Contact/CurrentEmployer
Contribute/Bookkeeping (remove copy & paste code)
Event/ParticipantCount
Event/ParticipantListing
Membership/Summary
Before
unnecessary joins to phone, email and address tables
After
join only when needed, code standardised
Technical Details
This also aligns the approach with that used in the extended report extension - there might be some notices as I have updated the extension where the signature differs from core but will need to drop a new release & people will need to be on it.
Comments
@yashodha now this one