CRM-21760: Manager Name is missing in 'Find Cases' search list #11665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcdservices
reviewed
Feb 16, 2018
CRM/Case/BAO/Case.php
Outdated
| @@ -1890,6 +1890,7 @@ public static function getCaseManagerContact($caseType, $caseId) { | |||
| } | |||
|
|
|||
| $caseManagerContact = array(); | |||
There was a problem hiding this comment.
I think this line can be removed. The var is not used in this function.
|
Tested and this is working as expected. Just one minor inline comment re: code cleanup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Steps to replicate:
Result: In place of manager name, we got '—' for all cases
Expected: Linkable manger name
Before
After
Comments
This is a regression due improvement made in #11304 where now
getCaseManagerContact()return the Case Manager name in HTML format.