Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2 Display Inbound Email: linefeed fixed #11661

Merged
merged 1 commit into from
Feb 12, 2018

Conversation

Detsieber
Copy link
Contributor

@Detsieber Detsieber commented Feb 9, 2018

Overview

When viewing an activity of type inbound email, the text is displayed in "details". However, although the database contains it in plain text and html, it is displayed as plain text without LFs, what makes it hardly readable.

Before

screenshot 2018-02-12 18 16 11

After

screenshot 2018-02-12 18 17 10

Technical Details

Small change (maybe a typo in the original code)

Comments

cudos to @bgm for helping to find the bug, and instructing me to create the PR !

@civicrm-builder
Copy link

Can one of the admins verify this patch?

@eileenmcnaughton
Copy link
Contributor

add to whitelist

@eileenmcnaughton
Copy link
Contributor

The after screenshot is missing from what I can see but I totally get the benefit of this PR

@eileenmcnaughton
Copy link
Contributor

Works a treat - I fixed up the PR template by adding the before & after

@eileenmcnaughton eileenmcnaughton merged commit b460b45 into civicrm:master Feb 12, 2018
@mlutfy
Copy link
Member

mlutfy commented Feb 12, 2018

Cross referencing, since the bot does not do it yet: https://lab.civicrm.org/dev/core/issues/2

Thank you @eileenmcnaughton @Detsieber !

@mlutfy mlutfy added this to the 4.7.31 milestone Mar 6, 2018
@jitendrapurohit
Copy link
Contributor

This seems to be causing problem in activity view which hold HTML template in details section. For eg. Send a simple email to http://dmaster.demo.civicrm.org/civicrm/contact/view?reset=1&cid=203 using one of the HTML template and load the activity view page (temporary link from dmaster). The details seems to be adding <br> for every new line contained in the HTML template.

image

Without this changes, it was rendered correctly.

@mlutfy
Copy link
Member

mlutfy commented Sep 5, 2018

@jitendrapurohit I opened a followup issue for the regression: https://lab.civicrm.org/dev/core/issues/379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants