Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test for CRM-20676 fix #11655

Merged
merged 1 commit into from
Feb 9, 2018

Conversation

monishdeb
Copy link
Member

@monishdeb monishdeb commented Feb 8, 2018

Overview

This PR extend an existing UT for #11461 fix


@monishdeb
Copy link
Member Author

monishdeb commented Feb 8, 2018

@eileenmcnaughton this will fail as it depends on #11461 fix.

@eileenmcnaughton
Copy link
Contributor

ah but it won't because you merged it :-)

@monishdeb
Copy link
Member Author

Nope it will fail because I merged that after submitting this PR, so test build will fail in this build but not on next 😉

@monishdeb
Copy link
Member Author

Jenkins test this please

@eileenmcnaughton
Copy link
Contributor

1/3 of the tests is a known issue (arg - needs fixing - that's on me) but the other 2 I don't recognise

@monishdeb
Copy link
Member Author

@eileenmcnaughton I have fixed the other 2 and submitted PR #11659 for that. Please have a look

@seamuslee001
Copy link
Contributor

Jenkins test this please

@eileenmcnaughton
Copy link
Contributor

unrelated fail

@eileenmcnaughton eileenmcnaughton merged commit b8a1503 into civicrm:master Feb 9, 2018
@mlutfy mlutfy added this to the 4.7.31 milestone Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants