Allow data-params to be specified as an item property and passed to CRM.api3 call #11639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@colemanw one for you I think - although the sprinters might perhaps be assigning review resources |
colemanw
reviewed
Feb 7, 2018
js/jquery/jquery.crmEditable.js
Outdated
| @@ -134,6 +135,9 @@ | |||
| $el = $($i), | |||
| params = {}, | |||
| action = $i.data('action') || info.action; | |||
| if (info.params) { | |||
| params = info.params; | |||
| } | |||
There was a problem hiding this comment.
This could be written more concisely by putting it inline with the variable declaration above:
params = info.params || {};
|
Makes sense to me. This js does not have any unit tests so the PR test results are irrelevant. But it's a safe change - just introducing a new option and not changing any existing functionality. |
|
Can you submit a PR for the docs update as well please? |
|
Doc PR: civicrm/civicrm-dev-docs#475 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See description in Jira - CRM-21741
Overview
A brief description of the pull request. Try to keep it non-technical.
Before
The current status. Please provide screenshots or gifs (LICEcap, SilentCast) where appropriate.
After
What has been changed. Please provide screenshots or gifs (LICEcap, SilentCast) where appropriate.
Technical Details
If the PR introduces noteworthy technical changes, please describe them here. Provide code snippets if necessary
Comments
Anything else you would like the reviewer to note