Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21719 Add a check in Civi/Install/Requirements to ensure that PHP… #11612

Merged
merged 1 commit into from
Jan 31, 2018

Conversation

seamuslee001
Copy link
Contributor

… Multibyte functions are enabled on install

Overview

This follows on from the previous PR on the issue and adds the check into Civi/Install/Requirements.php as per comment from @totten

ping @eileenmcnaughton @colemanw

@totten
Copy link
Member

totten commented Jan 30, 2018

(CiviCRM Review Template WORD-1.0)

  • (r-jira) Pass
  • (r-test) Pass
  • (r-code) Pass
  • (r-doc) Pass (too small; self-documenting)
  • (r-maint) Pass
  • (r-run) Pass: Executed by way of cv check-req. Also, manually hacked the patched code to simulate different scenarios and see they were reported.
  • (r-user) Pass: Trivial impact on UX -- one of many similar checks performed during installation
  • (r-tech) Pass: Trivial impact on existing integrations. Stays true to the contract of Civi/Install/Requirements.php.

@eileenmcnaughton eileenmcnaughton merged commit 7ca1649 into civicrm:master Jan 31, 2018
@eileenmcnaughton eileenmcnaughton deleted the crm-21719-civi branch January 31, 2018 00:27
@mlutfy mlutfy added this to the 4.7.31 milestone Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants