CRM-21719 Require Multibyte PHP extension

[seamuslee001]

Overview

Alters installation to require multibyte PHP functions

Before

mb_ not required

After

mb_ functions required for install

ping @totten @colemanw @mlutfy this i think would be needed to make mb_ functions required on install. I think this makes sense to do given how often we use an mb_ function in the codebase

---

• CRM-21719: Require Multibyte PHP Extension

[colemanw]

I agree with this change. Note however that this index.php is not always used e.g. when installing via the command line. So the status check is also important to keep around.

[totten]

tldr: I'd suggest replicating the test in Civi/Install/Requirements.php

longer: Early in the D8 project, Torrance extracted the list of requirements from the install folder and reproduced them in Civi/Install/Requirements.php, with the intent of making it available for use in hook_requirements. (This is actually used by in 8.x-master's civicrm.install file.)

I also recently used Civi\Install\Requirements as a building-block in the civicrm-setup library. The general idea is described more in this blog.

... So the status check is also important to keep around.

Perhaps CRM/Utils/Check/Env.php should also have a point where it calls Civi/Install/Requirements.php to ensure that the DB/PHP requirements are still met?

[colemanw]

Perhaps CRM/Utils/Check/Env.php should also have a point where it calls Civi/Install/Requirements.php to ensure that the DB/PHP requirements are still met?

That sounds like a good plan.