CRM-21687 fix issue with MariaDB 10.2 logging query writing due to cu… #11580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrent_timestamp and timestamp getting () added on the end in Maria10.2
seamuslee001
force-pushed
the
CRM-21687
branch
from
4379c45 to
91bd5c1
Compare
|
seems ok - are you able to test @gah242s |
|
Got this after rolling back and running upgrade again. Congratulations! Your upgrade was successful! Looks good from this standpoint. |
|
OK - I'm happy that this passed your testing & the unit test gives me confidence. Merging |
|
thanks @seamuslee001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rrent_timestamp and timestamp getting () added on the end in Maria10.2
Overview
In MariaDB 10.2 CURRENT_TIMESTAMP and TIMESTAMP get () added on at the end of the definition. This is my take on it following testing locally on a 10.2 Maria DB. i used str_ireplace as it seemed safer and more consistent with our current practices.
Before
Logging would not be able to be enabled on Maria10.2
After
Logging is able to be enabled
ping @gah242s @eileenmcnaughton @mlutfy @mattwire This has worked locally for me on a dmaster build. I have also tried added a unit test of the query writing hence the change to static function but that may have issues.