Test fixes, towards CRM-17647 #11574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test fixes towards never calling Contribution::Create without skipCleanMoney
|
|
||
| $this->assertEquals($params['trxn_id'], $contribution->trxn_id); |
There was a problem hiding this comment.
@eileenmcnaughton are we loosing anything by removing these asserts?
There was a problem hiding this comment.
I don't think so -creating contributions is tested elsewhere & these are tangental to what is being tested
|
I'm satisfied with the changes and reviewed to ensure that the tests aren't being reduced in a meaningful way. Happy for this to be merged now noting it only affects tests and the test suite has passed. |
|
thanks @seamuslee001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Test fixes towards never calling Contribution::Create without skipCleanMoney
Before
tests pass
After
tests pass. Less places where Contribution::create called without skipCleanMoney (via the api)
Technical Details
Towards #11539
Comments