Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21256 Improve performance of payment processor load #11563

Merged
merged 1 commit into from
Jan 25, 2018

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jan 21, 2018

Overview

Improve performance of "Submit Credit Card Contribution" page load.

Comments

Proposed replacement for #11060


@eileenmcnaughton
Copy link
Contributor Author

@mattwire ...

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 -per brief discussion - here is the comment docblock

  /**
   * Is there a processor on this site with the specified capability.
   *
   * The capabilities are defined on CRM_Core_Payment and can be extended by
   * processors.
   *
   * examples are
   *  - supportsBackOffice
   *  - supportsLiveMode
   *  - supportsFutureRecurDate
   *  - supportsCancelRecurring
   *  - supportsRecurContributionsForPledges
   *
   * They are passed as array('BackOffice');

But the issue is that many pages check for 'are there live processors' more than once so the goal here is to add caching once the question is answered

@seamuslee001
Copy link
Contributor

I guess the capabilities make for an OK array key i guess

@eileenmcnaughton
Copy link
Contributor Author

lol - that's for the enthusiastic review.. I guess

@seamuslee001
Copy link
Contributor

:-)

@seamuslee001
Copy link
Contributor

I am happy with the code and and think it won't do any harm and will hopefully improve performance

@eileenmcnaughton
Copy link
Contributor Author

much more enthused - I'm going to merge it off that since I think the test coverage is solid on this

@eileenmcnaughton eileenmcnaughton merged commit bba18c7 into civicrm:master Jan 25, 2018
@eileenmcnaughton eileenmcnaughton deleted the static branch January 25, 2018 04:51
@mlutfy mlutfy added this to the 4.7.31 milestone Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants