CRM-17647 fix for submitting payment with thousand separator

[eileenmcnaughton]

Overview

rc version of #11539

Note this does not cover all instances of mishandling the thousand separator - I believe they are well identified in #18839 but I am working through them

• CRM-17647: Recording payment truncates the amount after the comma (whether thousands or decimal separator)

[eileenmcnaughton]

test this please

[eileenmcnaughton]

@agh1 @colemanw @mlutfy test fail unrelated - fix required

[eileenmcnaughton]

also #11549 - there are some other places that need fixing for this bug but depend on this being merged

[eileenmcnaughton]

@agh1 @alifrumin you might like to give this a spin - it fixes some identified paths but there are more identified through the tests - although I probably won't work on those until this is merged

[eileenmcnaughton]

test fail unrelated

[eileenmcnaughton]

test this please

[seamuslee001]

test this please

[eileenmcnaughton]

@agh1 @colemanw @bgm this has passed

[agh1]

@eileenmcnaughton this is awesome--thanks! I was out sick and haven't had a chance to try it out, but @alifrumin and I will bang on it on Monday with partial payments, Spanish numbers, and anything else we can think of.

[eileenmcnaughton]

@agh1 - it fixes one path but there are others that don't work so don't see 'no broken places' as the bar for this fix

[eileenmcnaughton]

@agh1 are you looking at this today - just want to keep it moving because once this is merged I'm going to test for other places again (#11539 throws errors on 'risky paths' but then I have to dig into each one)

[abihazakariya]

@eileenmcnaughton, @agh1 and I tried the patch out and it is working as expected on both fronts: delimiters and partial payments.Thanks so much!

[eileenmcnaughton]

OK - I'm going to merge based on that (thank you for testing)

@agh1 I will also merge up to master - would still like you to keep reviewing & kicking the cans more on this