CRM-21672 fix intra-rc regression, fatal when deleting participants #11538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seamuslee001 FYI - just a regression we both missed - in case it triggers us to be a bit more wary of addField() (@colemanw ) |
eileenmcnaughton
force-pushed
the
regress
branch
2 times, most recently
from
5144733 to
53b2809
Compare
Change-Id: Iccbd17d53f07a93c74ce46e9539d1768019a2532
eileenmcnaughton
force-pushed
the
regress
branch
from
53b2809 to
240b0e6
Compare
|
Changes make sense to me and can understand reasoning for them. Code is clean and passes unit tests |
|
Thanks @seamuslee001 merging - good to fix regressions ASAP before the work they create is duplicated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Follow up fix to recent merged change. Fixes fatal when deleting a participant
Before
Fatal error prevents deleting a participant
After
Screen works
Technical Details
The issue is the addField function relies on the form having a specific action. Instead of just not adding the field when a form is used in delete rather than view/create mode it fatals. I've never been terribly sold on re-using view/create forms for delete & I'm not convinced addField should fail so hard. However, here I've fixed it by doing an early return based on form action.
Comments
This was caused by a patch merged in the last few days