CRM-21664 Modified--getting currencies from civicrm_currency table instead bein… #11533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g hard-coded. CRM-21664
|
Can one of the admins verify this patch? |
|
Jenkins ok to test |
|
This looks sane to me. I haven't tested this yet but seems sensible ping @monishdeb @eileenmcnaughton |
eileenmcnaughton
changed the title
|
OK I agree with this - there are at least 4 different currencies used in the test suite so I think we are covered on it |
|
@eileenmcnaughton @monishdeb Tests have passed now and I agree with Eileen that we probably have enough unit tests already to cover this |
|
Merged - I think this was your first PR merged? |
|
@eileenmcnaughton Yes this was my first one. |
|
Well done then - we need a pretty badge or something :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified file CRM/Core/PseudoConstant.php -- getting currencies from civicrm_currency table instead being hard-coded. CRM-21664
Before
Currencies were hardcoded and were missing some currencies like Serbian Dinar, code: RSD and when any contribution with that currency was tried to be created it resulted in error:
"error_message": "Currency not a valid code: "
After
All currencies in modification are being pulled from database table civicrm_currency instead of hardcoded.
Comments
Test by creating a contribution through API call mentioned in Jira issue.