CRM-14834 - fix activity export when relationship in export fields #11526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test this please |
eileenmcnaughton
force-pushed
the
export_fix_activity
branch
3 times, most recently
from
f92e371 to
fb86196
Compare
I was thinking this might fail but it is passing so let's lock it in caller
eileenmcnaughton
force-pushed
the
export_fix_activity
branch
from
fb86196 to
4d25113
Compare
|
test this please |
|
@eileenmcnaughton tested, this works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Per JIRA activity export fails if a relationship field is selected
Before
Fatal error when exporting activities from advanced search with a relationship field selected - per screenshot.
After
Export succeeds
Technical Details
Error was a really dumb bit of code - re-using the variable $query for a temp sql string.
Comments
I was able to replicate it in a unit test