CRM-21660 Remove use of deprecated function on mapping_type #11525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test this please |
2 similar comments
|
test this please |
|
test this please |
|
@monishdeb any chance you could review / merge this - pretty straight forward |
|
Agree, with the fix. Tested on my local, esp. on those pages which were touched with this minor fix. Working fine, merging now. |
|
Thanks @monishdeb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
remove deprecated function calls
Before
Usage of deprecated function
CRM_Core_OptionGroup::getValue('mapping_type', 'Import Activity', 'name');
After
Usage or recommended replacement
CRM_Core_BAO_Mapping::checkMapping($nameField, CRM_Core_PseudoConstant::getKey('CRM_Core_BAO_Mapping', 'mapping_type_id', 'Import Activity')
Technical Details
Comments
I kept this to a single field call for readability