CRM-21644, Fixed set default for Preferred Communication Method #11499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---------------------------------------- * CRM-21644: Preferred Communication Method is not set to default for contact https://issues.civicrm.org/jira/browse/CRM-21644
| @@ -2339,7 +2339,10 @@ public static function setProfileDefaults( | |||
| $defaults[$name . '_custom'] = $details[$name . '_custom']; | |||
| } | |||
| elseif ($name == 'preferred_communication_method') { | |||
| $v = explode(CRM_Core_DAO::VALUE_SEPARATOR, $details[$name]); | |||
| $v = $details[$name]; | |||
| if (!is_array($details[$name])) { | |||
There was a problem hiding this comment.
I think it would be slightly cleaner to use $v in the IF - but not a blocker in any way
|
I tested this & it works. It is a trivial form layer fix & as such I think it can get away without a unit test. Code looks fine. Merge on pass |
|
Jenkins re test this please |
|
Thanks @eileenmcnaughton |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
CRM-21644, Fixed set default for Preferred Communication Method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.civicrm.org/jira/browse/CRM-21644
Before
After