CRM-21634 Standardise search fields as they relate to contacts #11492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileenmcnaughton
force-pushed
the
search
branch
2 times, most recently
from
f9dae51 to
7546161
Compare
|
Jenkins re test this please |
|
test this please |
eileenmcnaughton
force-pushed
the
search
branch
from
7546161 to
a044038
Compare
CRM/Member/Form/Search.php
Outdated
| * @return string | ||
| */ | ||
| protected function getContactTypeLabel() { | ||
| return ts('Participant Contact Type'); |
There was a problem hiding this comment.
@eileenmcnaughton this needs to be changed to member
There was a problem hiding this comment.
ah yes, opps
|
eileenmcnaughton
force-pushed
the
search
branch
from
a044038 to
0573fd2
Compare
|
@seamuslee001 I fixed the line you pointed out & am adding merge on pass per your review |
|
ping @monishdeb @colemanw |
|
test this please |
1 similar comment
|
test this please |
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Feb 1, 2018
civicrm#11492 Bug: 184496 Change-Id: Id7edd36e043a7a3ce0f693a53da6d05af746747d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Standardise the fields available on different component searches (e.g tags is only available on Contribute, add to Member, Pledge & Participant). I only touched searches Participant, Contribute, Pledge & Member to keep scope manageable.
Before
After
Technical Details
I have increased the shared code component between these searches.
Comments
It would probably be easy to do this for some of the other searches but others have some extra complexity so have kept to the 'core four'. Also formatting inconsistency between searches is odd but pre-dates this