CRM-21616 ensure sql metadata is available from api #11476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileenmcnaughton
force-pushed
the
report
branch
from
2ff1e4f to
15d9e60
Compare
|
@civicrm-builder retest this please |
|
test this please |
3 similar comments
|
test this please |
|
test this please |
|
test this please |
|
@colemanw can we merge this - just adds debug data |
|
Agree with this change. Passed test build means it now correctly asserts the sql metadata retrieved from API also confirmed in local. Hence merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ensure that sql metadata is returned from the report api if requested
Before
Api call
$rows = civicrm_api3('report_template', 'getrows', array(
'report_id' => 'contribute/lybunt',
'yid_value' => 2015,
'yid_op' => 'fiscal',
'options' => array('metadata' => array('sql')))
was getting NULL returned as the sql
After
The metadata returned now includes the sql array
Technical Details
This worked at some point in the past but broke. It is mostly used for debugging, esp with unit test issues. Test added this time
Comments
Anything else you would like the reviewer to note