Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21613: Search issues on 'Manage Tag' page #11467

Merged
merged 1 commit into from
Dec 30, 2017

Conversation

monishdeb
Copy link
Member

@monishdeb monishdeb commented Dec 29, 2017

Overview

This PR fixes these two search issues:

  1. Cannot search level 2 or greater child tags using tag filter
  2. After any search, omitting/clearing search text by key doesn't restore the whole tag tree by stuck in old state

Before

test-multiple-before

After

test-multiple-after


@monishdeb
Copy link
Member Author

ping @colemanw @lcdservices

@lcdservices
Copy link
Contributor

tested and confirmed. this fixes issues when searching child tags that have not yet been exposed.

@colemanw
Copy link
Member

@monishdeb looks like the test failure is caused by this PR.

@colemanw
Copy link
Member

@colemanw colemanw merged commit b455fcc into civicrm:master Dec 30, 2017
@monishdeb monishdeb deleted the CRM-21613 branch December 30, 2017 18:06
sluc23 pushed a commit to ixiam/civicrm-core that referenced this pull request Jan 10, 2018
CRM-21613: Search issues on 'Manage Tag' page
@mlutfy mlutfy added this to the 4.7.31 milestone Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants