CRM-21602 Fix javascript error on Campaign/petition pages

[chandana-bandara]

Overview

Fixed the JavaScript error occurred when viewing and do actions on Campaigns page Campaigns/Surveys/Petitions. The bug report was continuous loading icon when enabling/disabling campaigns

Before

The loading icon did not disappear when enabling/disabling campaigns

After

The loading icon disappears when enabling/disabling campaigns

Technical Details

Added CRM.$ instead of $ for jQuery selectors where applicable.
Branch rebased to master.

Comments

There are 3 pages Campaign/Petition/Survey. The Campaign page uses
(function($){
})(CRM.$)
hence within that function, $ can be used freely instead of CRM.$.
But other two pages Petition/Survey do not use that technique. Therefore CRM.$ needs to be used instead of $.

---

• CRM-21602: Disable/Enable Campaign not working

[civicrm-builder]

Can one of the admins verify this patch?

[colemanw]

@coolbit thanks for the PR :)
Usually such a small change would have only one commit in the PR but this one has 3 (including a merge commit which we try to avoid). The way to fix that is by running

git rebase -i ecc71ac

Then put s for squash beside the two commits other than ecc71ac and save.

Then force push your changes git push -f and the PR will be clean :)

[chandana-bandara]

@colemanw Thanks!
I will follow your instructions above. But after that should I create a new PR?

[colemanw]

Force pushing to the same branch will just update this PR.

[chandana-bandara]

There is an issue while squashing the commits. It says "could not apply b638c71... Set version to 4.7.29". I think since there is a version change, it is having some difficulty.

Will that be OK if I take the master, do the fix and make a PR again? or what is the best way it should be done?

I'm quite new here and getting familiarized with the practices. Sorry for any inconveniences caused. Thanks,

[colemanw]

Ok try this:

git checkout CRM-21602
git reset --hard ecc71ac
git push -f

[chandana-bandara]

Did it. Please check :-)

[colemanw]

Looks great.
@civicrm-builder add to whitelist.