CRM-21609 - Correctly handle PayPalPro recurring payments whose amoun…

[MegaphoneJon]

…t doesn't match the initial contribution

Overview

If you make a recurring contribution of, say, $10/month with PayPal Pro, then change the amount to a different amount ($12/month), the card will be charged $12 but recorded as $10 in CiviCRM.

Before

See above.

After

Payment is recorded for the correct amount.

Technical Details

The Contribution.repeattransaction API passes through the $input[total_amount] value to the contribution create method. However, the value is stored in $input[amount], not $input[total_amount] for PayPal Pro.

Comments

I realize this could be more concise by initializing $input[total_amount] when we initialize $input['amount']. However, I have a private patch to support failed PayPal recurring payments that I'd like to pass upstream that would be affected.

[eileenmcnaughton]

Where I would like to go on this code is to have a function on CRM_Core_Payment called getAmount - there seem to be a few places where it is being calculated. I'm not opposed to merging this though since it solves a problem & seems harmless